hey I am very new to godot and I am trying to make a top down shooter but when I press the shoot button the game freezes

Question

extends KinematicBody2D

var speed = 500
var velocity = Vector2()
var bullet_speed = 2000
var bullet = preload("res://Bullet.tscn")

func getinput():
velocity = Vector2()
if Input.isactionpressed("right"):
velocity.x += 1
if Input.isactionpressed("left"):
velocity.x -= 1
if Input.isactionpressed("down"):
velocity.y += 1
if Input.isaction_pressed("up"):
velocity.y -= 1
velocity = velocity.normalized() * speed

look_at(get_global_mouse_position())

func physicsprocess(delta):
getinput()
velocity = moveand_slide(velocity)

if Input.is_action_pressed("LMB"):
    fire()

func fire():
var bulletinstance = bullet.instance()
bulletinstance.position = getglobalmouseposition()
bulletinstance.rotatedegress = rotationdegrees
bulletinstance.applyimpulse(Vector2(),Vector2(bulletspeed,0).rotated(rotation))
gettree().getroot().calldeferred("addchild",bulletinstance)

Comments

Just a guess, but it looks like you may be spamming the fire() function call since you're using is_action_pressed(). That'll call the function in every physics frame where the button is held down (so, by default, 60x per second). Assuming you want to fire only once per button press, change that call to is_action_just_pressed().

---

no, I tried didn't work still freezing I have tried every and it just does not work. thank you for trying to help

---

Hmmm... Unformatted code is really difficult to read, but I notice that you might have a typo here:

bullet_instance.rotate_degress = rotation_degrees

That rotate_degress can't be right, can it?

Further, assuming the problem is in the fire() function, you can try to comment out individual lines to find the offending code and further narrow down the problem...

Answer 1

inside your fire function change this

gettree().getroot().calldeferred("addchild",bulletinstance)

to this

get_parent.add_child(bulletinstance)

maybe solve the problem

Comments

no still not working
debugger: Parser error: the identifier "bulletinstance" isn't declared in the current scope