Character doesn't run right when ui_right pressed cannot see why

Question

Here is the code: please help!

extends KinematicBody2D

const SPEED = 100
const GRAVITY = 10
const JUMP_POWER = -250
const FLOOR = Vector2(0, -1)
var isAttacking = false

var velocity = Vector2()

var on_ground = false


func _physics_process(delta):
    if Input.is_action_pressed("ui_right") && isAttacking == false:
        velocity.x = SPEED
        $AnimatedSprite.play("Run")
        $AnimatedSprite.flip_h = false
    if Input.is_action_pressed("ui_left") && isAttacking == false:
            velocity.x = -SPEED
            $AnimatedSprite.play("Run")
            $AnimatedSprite.flip_h = true
    else:
        velocity.x = 0
        if on_ground == true:
            if isAttacking ==false:
                $AnimatedSprite.play("Idle")

    if Input.is_action_pressed("ui_up"):
        if on_ground == true:
            velocity.y = JUMP_POWER
            on_ground = false
    if Input.is_action_just_pressed("Attack"):
        if on_ground == true:
            $AnimatedSprite.play("Attack")
            isAttacking = true

    velocity.y += GRAVITY

    if is_on_floor():
        on_ground = true
    else:
        on_ground = false
        if velocity.y < 0:
            $AnimatedSprite.play("Jump")
        else:
            $AnimatedSprite.play("Fall")

    velocity = move_and_slide(velocity, FLOOR)



func _on_AnimatedSprite_animation_finished():
    if $AnimatedSprite.animation == "Attack":
        isAttacking = false

Comments

Because gdscript is indent-sensitive, it's really difficult to point out potential script problems in unformatted code. Please edit your post and format the code. To do that, just select all of the code and press the { } button in the editor's toolbar.

---

Hi, thanks for that.

Answer 1

Is your variable "onground" true when you press "uiright"?

If "on_ground" is true, I don't see anything wrong, maybe your node is already colliding with another one, and that keeps him from moving?

If you have nodes in your scene that can collide with your character, try disabling them. Just keep the ground and test.

Comments

Hi thanks for the reply. Still no luck. Pressing right turns the character but freezes in space. What is confusing is that when the if statement for uileft is taken out, then uiright works fine.

---

Solved! I changed the second "if" to "elif".

Thanks for the help!

---

Yes... I did not see the if ... if ... else!

Good if you solved your problem!!!