Can someone help me with a problem from the tutorial "make your first 2D game with Godot"

Question

I was following the video "make your first 2d game with Godot" and while I was working on the part called "Preventing the velocity from resetting every frame" i noticed that my "player character" wouldn't jump after I looked threw the comments and found the line replacement for 13 on the player and it still wouldn't work.

https://www.youtube.com/watch?v=Mc13Z2gboEk&t=3625s

Comments

Can you upload your project or at least the relevant portions of code? There can be a lot of reasons why something like a jump isn't working and I won't guess...

---

Player Code :
extends Actor

func physicsprocess(delta: float) -> void:
var direction: = getdirection()
velocity = calculatemovevelocity(velocity, direction, speed)
velocity = moveandslide(velocity, FLOORNORMAL)

func getdirection() -> Vector2:
return Vector2(
Input.getactionstrength("moveright") - Input.getactionstrength("moveleft"),
-1.0 if Input.getactionstrength("jump") and ison_floor() else 0.0
)

func calculatemovevelocity(
linearvelocity: Vector2,
speed: Vector2,
direction: Vector2
) -> Vector2:
var newvelocity: = linearvelocity
newvelocity.x = speed.x * direction.x
newvelocity.y += gravity * getphysicsprocessdeltatime()
if direction.y == -1.0:
newvelocity.y = speed.y * direction.y
return new_velocity

///////////////////////////////////////////////////////////////////////////////////////////////////////////////
Actor Code:
extends KinematicBody2D
class_name Actor

const FLOOR_NORMAL: = Vector2.UP

export var speed: = Vector2(300.0,1000.0)
export var gravity: = 4000.0

var velocity: = Vector2.ZERO

---

below is what i did (notice there is a spelling mistake in calculate hece i changed the same in line 9)

extend the parent note aCTOR.gd

extends Actor

Load Physics (properties)

func physicsprocess(delta: float) -> void:

loading variable direction

var direction: = get_direction()

defining calclatemovevelocity sice it was crashing with parse error I declared it here, still the gravity isn't working

func calclatemovevelocity(speed, direction, velocity):

velocity = calclate_move_velocity(speed, direction, velocity)
velocity = move_and_slide(velocity)

func getdirection() -> Vector2:
return Vector2(
Input.getactionstrength("moveright") - Input.getactionstrength("moveleft"),
-1.0 if Input.isactionjustpressed("jump-up") and isonfloor() else 1.0
)

warning-ignore:unreachable_code

warning-ignore:unreachable_code

func calculatemovevelocity(
speed: Vector2,
direction: Vector2,
linear_velocity: Vector2
) -> Vector2:

new velocity

    var new_velocity: = linear_velocity
    new_velocity.x = speed.x * direction.x
    new_velocity.y += gravity * get_physics_process_delta_time()
    if direction.y == -1.0: 
        velocity.y = speed.y * direction.y

    return speed * direction

Answer 1

You mixed up the order of arguments: your calculate_move_velocity-function expects speed as the second and direction as the third argument, but you passed direction as the second one and speed as the third one instead.

---

For future questions please make sure that your code is formatted properly (each line has to start with 4 spaces, each additional 4 spaces equal an indentation layer). If you don't, underscores are interpreted as markdown and indentation is lost, which makes your script a lot harder to read for others trying to help you.

Comments

Thanks it helped me as well